Fix additional crashes. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hInfo->error is reset within the decode_* functions. This caused the decoder to ignore errors for some channels in the error resilience (ER) code path. Fixes knik0#58.
The frontend does not support audio output when the number of channels changes between frames. Check if the number of decoded channels matches the number of audio output channels. It is possible that this condition should be detected in the decoder instead of the frontend. Fixes crash from afl-fuzz.
|
Thank you very much for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58 and an additional crash found with afl-fuzz.
I'm not a huge fan of the either fix in terms of elegance, but they should are simple and straight forward to understand.