-
Notifications
You must be signed in to change notification settings - Fork 5
KDS-607: Update kds dependencies #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates KDS (KNIME Design System) dependencies to version 0.0.8 to fix subpixel rendering issues for icons in xsmall size. The changes ensure consistent dependency versions across the workspace by adding both packages to the workspace catalog and updating the demo package to use the catalog reference.
- Updated
@knime/kds-componentsfrom 0.0.5 to 0.0.8 - Added
@knime/kds-styles0.0.8 to workspace catalog - Migrated demo package to use catalog reference for
@knime/kds-styles
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds kds-styles to catalog and updates kds-components version |
| demo/package.json | Changes kds-styles dependency from hardcoded version to catalog reference |
| .changeset/ninety-bars-flash.md | Documents the patch-level change for icon rendering fix |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
64ead66 to
2b82448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2b82448 to
f78a7ae
Compare
KDS-607 (Subpixel rendering issues for icons in size xsmall)