Skip to content

Conversation

@ChristianAlbrecht
Copy link
Contributor

KDS-607 (Subpixel rendering issues for icons in size xsmall)

Copilot AI review requested due to automatic review settings October 21, 2025 07:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates KDS (KNIME Design System) dependencies to version 0.0.8 to fix subpixel rendering issues for icons in xsmall size. The changes ensure consistent dependency versions across the workspace by adding both packages to the workspace catalog and updating the demo package to use the catalog reference.

  • Updated @knime/kds-components from 0.0.5 to 0.0.8
  • Added @knime/kds-styles 0.0.8 to workspace catalog
  • Migrated demo package to use catalog reference for @knime/kds-styles

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
pnpm-workspace.yaml Adds kds-styles to catalog and updates kds-components version
demo/package.json Changes kds-styles dependency from hardcoded version to catalog reference
.changeset/ninety-bars-flash.md Documents the patch-level change for icon rendering fix
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 21, 2025 13:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ChristianAlbrecht ChristianAlbrecht force-pushed the bug/KDS-607-update-dependencies branch 2 times, most recently from 64ead66 to 2b82448 Compare October 21, 2025 13:38
Copilot AI review requested due to automatic review settings October 21, 2025 13:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

KDS-607 (Subpixel rendering issues for icons in size xsmall)
KDS-607 (Subpixel rendering issues for icons in size xsmall)
KDS-607 (Subpixel rendering issues for icons in size xsmall)
@ChristianAlbrecht ChristianAlbrecht force-pushed the bug/KDS-607-update-dependencies branch from 2b82448 to f78a7ae Compare October 21, 2025 14:02
@ChristianAlbrecht ChristianAlbrecht merged commit 4099706 into master Oct 21, 2025
5 checks passed
@ChristianAlbrecht ChristianAlbrecht deleted the bug/KDS-607-update-dependencies branch October 21, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants