Matgar26 kno 5091 modules #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
January 24, 2024 15:32
…atgar26-kno-5091-modules # Conflicts: # Sources/Helpers/Utilities.swift # Sources/Knock.swift # Sources/KnockAPI.swift # Sources/KnockAppDelegate.swift # Sources/Modules/Channels/ChannelService.swift # Sources/Modules/Feed/FeedManager.swift # Sources/Modules/Feed/Models/FeedClientOptions.swift # Sources/Modules/Feed/Models/FeedItemScope.swift # Sources/Modules/Preferences/PreferenceService.swift # Sources/Modules/Users/UserService.swift
matgar26
added a commit
that referenced
this pull request
Mar 20, 2024
* Initialization Strategy and Unregistering from Push (#2) * Starting on initial refactor * initial refactor * Implemented shared Knock instance * added device unregistration functionality * Added more safety around the userId checks * Cleanup * Make KnockError a LocalizedError * Updated KnockOptions init * updates * Matgar26 kno 5091 modules (#3) * Starting on initial refactor * initial refactor * Implemented shared Knock instance * added device unregistration functionality * Added more safety around the userId checks * Cleanup * Make KnockError a LocalizedError * Updated KnockOptions init * updates * Introduce Modules and Services for independent responsibilities * Authentication * fixes * set version on api base path * Fixes * fix * implementation fix * Updated logging * Working on tests * created shared Knock instance * refactored logging * refactored logging * Adding more tests * [KNO-5189]: Token management and doc updates (#4) * Documentation updates and refactor KnockEnvironment to be and actor to avoid race conditions * adding token handling * readme updates * Added migration guide * Small fixes * Added additional props to FeedItem * Cleanup * final cleanup * spelling fix * Cleanup based on PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.