From 07677acafb05ff2f8359f5b1a6e78cb520de9f1a Mon Sep 17 00:00:00 2001 From: Colton Clemmer Date: Wed, 9 Aug 2017 16:04:50 -0500 Subject: [PATCH] Add toString function to subscribable --- spec/asyncBehaviors.js | 5 +++++ src/subscribables/subscribable.js | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/spec/asyncBehaviors.js b/spec/asyncBehaviors.js index f2dc534eb..8403b691f 100644 --- a/spec/asyncBehaviors.js +++ b/spec/asyncBehaviors.js @@ -218,6 +218,11 @@ describe('Rate-limited', function() { jasmine.Clock.tick(250); expect(notifySpy).toHaveBeenCalledWith('b'); }); + + it('Should return "[object Object]" with .toString', function() { + // Issue #2252: make sure .toString method does not throw error + expect(new ko.subscribable().toString()).toBe('[object Object]') + }); }); describe('Observable', function() { diff --git a/src/subscribables/subscribable.js b/src/subscribables/subscribable.js index 27f71faff..d6e39ab29 100644 --- a/src/subscribables/subscribable.js +++ b/src/subscribables/subscribable.js @@ -163,6 +163,10 @@ var ko_subscribable_fn = { return !this['equalityComparer'] || !this['equalityComparer'](oldValue, newValue); }, + toString: function() { + return '[object Object]' + }, + extend: applyExtenders };