JQuery Accordian not rendering nested accordians with knockout 2.2.0 #852

Closed
RandyJames opened this Issue Feb 19, 2013 · 1 comment

Comments

Projects
None yet
2 participants

A demonstration of the issue is in this stackoverflow item
http://stackoverflow.com/questions/13628054/having-trouble-with-jqueryui-accordion-and-knockoutjs/14836217#14836217

I've had success with knockout 2.1.0 in many similar cases.

To reproduce, use this jsfiddle:
http://jsfiddle.net/NE6dm/

simply change the knockoutjs version from 2.2.0 to 2.1.0

Owner

mbest commented Feb 19, 2013

Yes, there was a change in Knockout 2.2 regarding the foreach binding. In 2.1, the foreach binding was sometimes erroneously exposing it's dependency to sibling bindings, and this was fixed in 2.2.

So the real bug is in the jqAccordion binding because it doesn't have any dependency that will cause it to update. I was able to make it work by adding an option to jqAccordion to give it the correct dependency: http://jsfiddle.net/mbest/NE6dm/1/

BTW, this shows how it also doesn't work in 2.1.0 when the foreach binding is specified differently: http://jsfiddle.net/mbest/NE6dm/2/

mbest closed this Feb 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment