From be675724985f4dfec43c08f66d95823995b58c77 Mon Sep 17 00:00:00 2001 From: Brian M Hunt Date: Sat, 16 Dec 2017 09:38:26 -0500 Subject: [PATCH] #5 c29a923 79d3f5f --- .../{visibleBehaviors.js => visibleHiddenBehaviors.js} | 4 ++-- packages/tko.binding.core/src/visible.js | 10 +++++++--- 2 files changed, 9 insertions(+), 5 deletions(-) rename packages/tko.binding.core/spec/{visibleBehaviors.js => visibleHiddenBehaviors.js} (93%) diff --git a/packages/tko.binding.core/spec/visibleBehaviors.js b/packages/tko.binding.core/spec/visibleHiddenBehaviors.js similarity index 93% rename from packages/tko.binding.core/spec/visibleBehaviors.js rename to packages/tko.binding.core/spec/visibleHiddenBehaviors.js index a01dce07..89d2c749 100644 --- a/packages/tko.binding.core/spec/visibleBehaviors.js +++ b/packages/tko.binding.core/spec/visibleHiddenBehaviors.js @@ -27,7 +27,7 @@ describe('Binding: Visible', function () { provider.bindingHandlers.set(coreBindings) }) - it('Should display the node only when the value is true', function () { + it('Visible means the node only when the value is true', function () { var myObservable = observable(false) testNode.innerHTML = "" applyBindings({ @@ -39,7 +39,7 @@ describe('Binding: Visible', function () { expect(testNode.childNodes[0].style.display).toEqual('') }) - it('Should unwrap observables implicitly', function () { + it('Visible should unwrap observables implicitly', function () { var myObservable = observable(false) testNode.innerHTML = "" applyBindings({ diff --git a/packages/tko.binding.core/src/visible.js b/packages/tko.binding.core/src/visible.js index 44917a5a..7b2626cc 100644 --- a/packages/tko.binding.core/src/visible.js +++ b/packages/tko.binding.core/src/visible.js @@ -5,13 +5,17 @@ import { export var visible = { update: function (element, valueAccessor) { var value = unwrap(valueAccessor()) - var isCurrentlyVisible = !(element.style.display == 'none') - if (value && !isCurrentlyVisible) { element.style.display = '' } else if ((!value) && isCurrentlyVisible) { element.style.display = 'none' } + var isCurrentlyVisible = !(element.style.display === 'none') + if (value && !isCurrentlyVisible) { + element.style.display = '' + } else if (!value && isCurrentlyVisible) { + element.style.display = 'none' + } } } export var hidden = { update: function (element, valueAccessor) { - visible.update.call(this, element, function () { return !unwrap(valueAccessor()) }) + visible.update.call(this, element, () => !unwrap(valueAccessor())) } }