Support JSX and Slots #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cross-linking cssinjs/jss#728 |
This is not intended to be especially performant, and there are a number of key benefits we could add (e.g. ensuring we don’t clobber data between observable updates). Note a few clean-ups to templating behavior, where JSX templating would eventually go.
Note that we need commonjs transformer to import, at least until they have esm support.
We’re waiting on ESM support in jss to avoid a number of build issues with rollup and karma. See cssinjs/jss#733
brianmhunt
changed the title
|
Note that this was supposed to include Until a jss library is available in esm or otherwise, we'll put the jss part off. In the mean time, it's simple to include in a custom component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #66