Skip to content

Nick O'Leary knolleary

Organizations

cfibmers node-red
Nick O'Leary
regarding shape of nodes
knolleary commented on issue node-red/node-red#263
Nick O'Leary

No, the shape of the node cannot be customised. The docs describe what can be customised. For general questions, rather then specific issues, pleas…

knolleary commented on issue node-red/node-red#261
Nick O'Leary

I've been thinking about this for a while. The problem with starting to auto parse the payload is it will instantly break everyone's flows that cur…

knolleary commented on pull request node-red/node-red#260
Nick O'Leary

Merged - and working. Thanks @hindessm! :thumbsup:

Nick O'Leary
knolleary merged pull request node-red/node-red#260
Nick O'Leary
Test coverage on coveralls.io
2 commits with 5 additions and 1 deletion
Nick O'Leary
  • Nick O'Leary 3db84d5
    HTTP Out payload: relax null checking
Nick O'Leary
  • Nick O'Leary 4d03189
    Http Out: remove excess debug
Nick O'Leary
  • Nick O'Leary a7e7254
    Handle null response payloads
Nick O'Leary
  • Nick O'Leary 8e24a95
    HTTP Out - stringed the wrong bit
Nick O'Leary
  • Nick O'Leary bd80cf4
    HTTP Out - header properties must be strings
knolleary commented on pull request node-red/node-red#260
Nick O'Leary

node-red-gitbot: please recheck the cla status

knolleary commented on pull request node-red/node-red#259
Nick O'Leary

Thanks for spotting this. As stated in our contributing guidelines, we cannot accept a pull request without a signed CLA. I'm going to close this P…

knolleary commented on issue node-red/node-red#258
Nick O'Leary

Duplicate of #5

knolleary commented on pull request node-red/node-red#251
Nick O'Leary

No... Ran out of time to test it properly last week. Am away on holiday this week, might get a chance to look but can't guarantee it.

knolleary commented on pull request node-red/node-red#251
Nick O'Leary

Heh - I wasn't going to beat you up on the jshint stuff as we've only just added that in - but thanks for sorting it out. Will test it out tonight.

knolleary commented on issue node-red/node-red#124
Nick O'Leary

@andrewwolverton I presume you've redacted the server url in those log messages... but the fact they contain "http://" doesn't look right. You shou…

Nick O'Leary
knolleary merged pull request node-red/node-red#254
Nick O'Leary
Added dynamic category capability
4 commits with 97 additions and 109 deletions
knolleary commented on pull request node-red/node-red#251
Nick O'Leary

Finally gone through this. Only issue I've spotted walking the code (rather than running - so correct me if I'm wrong) is _creds gets attached to t…

knolleary commented on pull request node-red/node-red#251
Nick O'Leary

convertNode is used in two places. createCompleteNodeSet which creates the complete JSON to be deployed to the runtime - this should include the c…

knolleary commented on pull request node-red/node-red#254
Nick O'Leary

Tested locally - all looks good but for one final thing - the exclusion list needs 'deprecated' adding.

knolleary commented on pull request node-red/node-red#254
Nick O'Leary

This should be: ['config','deprecated']

Nick O'Leary
  • Nick O'Leary 9db1166
    Fix logHandler array handling
Nick O'Leary
TypeError exception in "twitter in" node?
knolleary commented on issue node-red/node-red#257
Nick O'Leary

On the case already - fix forthcoming

Nick O'Leary

I know we have a philosophical difference of opinion over whether single-line statements should still be on new lines, but I won't go around changi…

Nick O'Leary
  • Nick O'Leary 3de2f3d
    Add jshint:core to default build
Nick O'Leary
Nick O'Leary
  • Nick O'Leary 649c82f
    Fix all jshint warnings in core code
Something went wrong with that request. Please try again.