Skip to content

Migrate dunst from iniparser to inih. #18

Closed
wants to merge 1 commit into from

2 participants

@algernon

Instead of using iniparser, which is rarely packaged, and is an external dependency, use an embedded copy of inih instead, which is only a hundred or so lines, and can do pretty much the same as iniparser.

The benefit is one less external dependency, and it makes it easier for distributions to package dunst.

This also fixes issue #12.

@algernon algernon Migrate dunst from iniparser to inih.
Instead of using iniparser, which is rarely packaged, and is an
external dependency, use an embedded copy of inih instead, which is
only a hundred or so lines, and can do pretty much the same as
iniparser.

The benefit is one less external dependency, and it makes it easier
for distributions to package dunst.

Signed-off-by: Gergely Nagy <algernon@balabit.hu>
c3f25f8
@knopwob
Owner
knopwob commented Jun 20, 2012

Did you use 2 different editors to write this? Because it's a mixture of tabs and spaces. It's not a problem; I'm just curious how this happend.

Other than that everything looks fine. I've pulled (locally) and fixed the issues above. If I don't encounter any problems, I'll merge this into master soon. I'll also add a AUTHORS file; how would you like to be mentioned there?

@algernon

As for the editor, I used only one, but forgot to set it to only use spaces, and it defaulted to using a mixture when I told it not to use GNU-style indentation. Sorry about that!

Regarding the AUTHORS file: I don't think it's necessary to mention me there, it's a tiny little patch, and attribution in git log is good enough for me. But if you want to, whatever I used for the Signed-off-by is good.

@algernon

Since you merged this, and touched it up, lets close the pull request too! :)

@algernon algernon closed this Jun 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.