Skip to content

Progress hints #71

Merged
merged 9 commits into from Oct 8, 2012

2 participants

@progandy
progandy commented Oct 7, 2012

Enables display of progress hints and includes some necessary bugfixes for clean progress updates.

@knopwob
Owner
knopwob commented Oct 7, 2012

What's the advantage of doing this within the daemon instead of letting the client add the progress information to the summary or body?

And the new format placeholder should be documented in the manpage (README.pod) and the default dunstrc.

Apart from this and the inline comments this looks fine.

@progandy
progandy commented Oct 7, 2012

You are right, this should be done in the summary. I didn't think of that since xfce4-notifyd did not display the text at all.

If you still want to add it I'll clean up the comments later.

@knopwob
Owner
knopwob commented Oct 7, 2012

Since it seems to be already used by other notification-daemons and clients this should be useful to increase compatibility.
So yes, I still want to merge this ;)

Thank you!

P.s: Please leave a short comment when you're done, since (at least I think) github doesn't send notifications when the pullrequest gets upated

@progandy
progandy commented Oct 8, 2012

I think it is ready.

@knopwob knopwob merged commit 75cb6da into knopwob:master Oct 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.