Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes labels mixed up with Neo4j Output #142

Closed
lalquier opened this issue Oct 11, 2019 · 10 comments

Comments

@lalquier
Copy link

@lalquier lalquier commented Oct 11, 2019

After the presentation at NODES 2019, I gave this version of kettle a try: kettle-neo4j-remix-8.2.0.7-719-REMIX.zip

I tried it on a simple transformation providing these fields to the Neo4j output step:
Source, Target, Source Label, Target Label, Relationship

This worked fine with the stable plugin from the PDI community edition.
With this version of kettle, the same mapping leads to the creation of nodes with labels that don't make much sense. It feels as if the source and target labels are switched for some reason, which leads to the creation of incorrect nodes.

Is that a known issue with this version?

@lalquier

This comment has been minimized.

Copy link
Author

@lalquier lalquier commented Oct 15, 2019

I did more troubleshooting and I boiled the issue down to the use of Fields for Source/Target node labels and Relationships.
If I use static values for the labels, everything works fine.

The problem, of course, is that it is not practical to filter all possible combinations of source label, target label and relationship type using static values.

The previous version handled label mapping using fields for a single list of mixed relationships.
This version doesn't seem to work the same.

@mattcasters

This comment has been minimized.

Copy link
Collaborator

@mattcasters mattcasters commented Oct 15, 2019

Thanks for the feedback Laurent. I'll try to find a reproduction path and if I have one I'll add an integration test.

@lalquier

This comment has been minimized.

Copy link
Author

@lalquier lalquier commented Oct 15, 2019

Thanks for the reply. I can provide more details with file samples and screenshots, or even a live call to walk you through what I am doing if you want. Just let me know.
I wasn't sure this is the right place for this level of details (that and attaching pictures to github issues isn't very practical :) ).

mattcasters added a commit to mattcasters/knowbi-pentaho-pdi-neo4j-output that referenced this issue Oct 21, 2019
mattcasters added a commit that referenced this issue Oct 21, 2019
Issue #142
@mattcasters

This comment has been minimized.

Copy link
Collaborator

@mattcasters mattcasters commented Oct 21, 2019

I think I found the culprit in the code. Will get you a build.

mattcasters added a commit that referenced this issue Oct 22, 2019
Issue #142 and #144
@mattcasters

This comment has been minimized.

Copy link
Collaborator

@mattcasters mattcasters commented Oct 22, 2019

Could you give release 4.1.2 a try? Thanks a lot!

@lalquier

This comment has been minimized.

Copy link
Author

@lalquier lalquier commented Oct 24, 2019

Thanks. It will take me a while to find the time to set up maven and compile the code but I will try to do that as soon as I can!

@mattcasters

This comment has been minimized.

Copy link
Collaborator

@mattcasters mattcasters commented Oct 24, 2019

Or just download a release 👍

@mattcasters

This comment has been minimized.

Copy link
Collaborator

@mattcasters mattcasters commented Oct 30, 2019

My colleagues reported the bug as fixed

@lalquier

This comment has been minimized.

Copy link
Author

@lalquier lalquier commented Oct 30, 2019

I finally got around to testing the latest release and I am afraid it is still happening on my end. I did a clean install of Kettle and removed the Neo4j Output plugin before replacing it with the new release (4.1.2).

I have a test file that adds 12 relationships between nodes that already exist in the database.
After running the import, my number of nodes jump from 1015 to 1021 instead of remaining the same.

@mattcasters

This comment has been minimized.

Copy link
Collaborator

@mattcasters mattcasters commented Oct 31, 2019

Hi Laurent, it would be really great if you could create a simple reproduction example. Please create a new issue for it then because what you describe doesn't seem the same as this issue. Thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.