[WIP] - Improve display errors #22
Conversation
* 'master' of github.com:knowbody/crra: fix some bugs (knowbody#6)
* 'master' of github.com:knowbody/crra: (25 commits) Correct build-source path (knowbody#18) v0.1.10 make changes to cli (knowbody#17) Update README.md v0.1.9 add chmod to build script (knowbody#14) v0.1.8 update permissions (knowbody#12) v0.1.7 Set file permissions on copy, and add README.md to template (knowbody#11) v0.1.6 add back webpack config v0.1.5 chenage permissions to copy.js v0.1.4 add scripts/copy.js back v0.1.3 fix bin in package.json v0.1.2 fix repo url ...
|
This is great! I'm wondering if we could also be showing these errors in the browser, while in DEV mode? |
|
We certainly could. webpack-dev-server does allow for an overlay and I can work on that this week. I figured this would be nice so you don't have to run everything in 2 different terminal sessions. |
|
Added a few more things:
If there is an error, it will put it under it's respective compiler.
If anyone feels like it, test it out and let's see how people feel about it! |
|
@tzilist this is amazing! the repo changed a bit since last time, do you mind syncing with master please |
|
Ok, updated! Process now exits on webpack errors and decides whether to use |
|
Again this is great! Thank you for the PR! |
|
@tzilist I released the version (v0.2.1) with the error display, but I'm not sure it works properly. It doesn't seem to update JS files, and I can't see any errors being displayed in the browser. Do you mind having a look into it please? |
|
On it! |
|
@knowbody So, I just tested this out on a different machine and it seems to be working properly. Can you maybe upload your project so I can take a look? Also, we should probably make sure the users have berror installed as this heavily relies on it. Maybe we can add a link to install |
|
I think we could do it as a devDependency
…On Thu, 15 Jun 2017 at 18:32, Theodore Zilist ***@***.***> wrote:
So, I just tested this out on a different machine and it seems to be
working properly. Can you maybe upload your project so I can take a look?
Also, we should probably make sure the users have berror installed as this
heavily relies on it. Maybe we can add a link to install reason-cli to
the package.json?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADoDp7hOGUQNJwX-UBgoL59-ZgSXcqAnks5sEWqagaJpZM4N2RGR>
.
|
This PR is very much a WIP. Currently, we need to watch the error outputs from webpack and bsb while developing. This PR attempts to work on issue #3 .
Currently, we spawn a process for
bsb -make-work -w,webpack-dev-server -wandberror. Currently,berrorseems like a pain to use so this may need to change. We then keep track of the status of webpack and bsb compilation errors/successes and log those to the console.Each time a file is saved, the terminal is updated in real time to reflect the current status of each compiler.
Here are a few screenshots of what this currently looks like in the terminal.
Keep in mind this relies heavily on
berrorcurrently which very much is still in beta.