300 mBTC Bounty - Remove PollingTradeService deprecated `getTradeHistory` #1064

Closed
timmolter opened this Issue Sep 21, 2015 · 7 comments

Comments

Projects
None yet
3 participants
@timmolter
Member

timmolter commented Sep 21, 2015

... and update all implementations to use the getTradeHistory(TradeHistoryParams params) if necessary.

@timmolter timmolter added the Bounty label Sep 21, 2015

@rafalkrupinski

This comment has been minimized.

Show comment
Hide comment
@rafalkrupinski

rafalkrupinski Sep 22, 2015

Contributor

Let me do it

Contributor

rafalkrupinski commented Sep 22, 2015

Let me do it

@rafalkrupinski

This comment has been minimized.

Show comment
Hide comment
@rafalkrupinski

rafalkrupinski Sep 22, 2015

Contributor

@felipelalli You were the original author of the MercadoBitcoin code, would you please verify if getTradeHistory works properly? Thanks!

Contributor

rafalkrupinski commented Sep 22, 2015

@felipelalli You were the original author of the MercadoBitcoin code, would you please verify if getTradeHistory works properly? Thanks!

@felipelalli

This comment has been minimized.

Show comment
Hide comment
@felipelalli

felipelalli Sep 23, 2015

Contributor

Sure. I'm in vacation, next week I can see it. Is it OK?

@felipelalli https://github.com/felipelalli You were the original
author of the MercadoBitcoin code, would you please verify if
getTradeHistory works properly? Thanks!


Reply to this email directly or view it on GitHub
#1064 (comment).

Contributor

felipelalli commented Sep 23, 2015

Sure. I'm in vacation, next week I can see it. Is it OK?

@felipelalli https://github.com/felipelalli You were the original
author of the MercadoBitcoin code, would you please verify if
getTradeHistory works properly? Thanks!


Reply to this email directly or view it on GitHub
#1064 (comment).

@timmolter

This comment has been minimized.

Show comment
Hide comment
@timmolter

timmolter Sep 23, 2015

Member

@rafalkrupinski Thank you! What BTC address should I send the bounty to?

Member

timmolter commented Sep 23, 2015

@rafalkrupinski Thank you! What BTC address should I send the bounty to?

@rafalkrupinski

This comment has been minimized.

Show comment
Hide comment
@rafalkrupinski

rafalkrupinski Sep 23, 2015

Contributor

@felipelalli Sure thing, thanks again!

Contributor

rafalkrupinski commented Sep 23, 2015

@felipelalli Sure thing, thanks again!

@timmolter

This comment has been minimized.

Show comment
Hide comment
@timmolter

timmolter Sep 23, 2015

Member

Paid. Thanks!

Member

timmolter commented Sep 23, 2015

Paid. Thanks!

@timmolter timmolter closed this Sep 23, 2015

@felipelalli

This comment has been minimized.

Show comment
Hide comment
@felipelalli

felipelalli Sep 30, 2015

Contributor

@rafalkrupinski I am back from vacation, but to be honest I can't have a look on this soon. But eventually I'll use the API in the future, so if I find anything wrong I send a patch to fix. Thank you and I am sorry.

Contributor

felipelalli commented Sep 30, 2015

@rafalkrupinski I am back from vacation, but to be honest I can't have a look on this soon. But eventually I'll use the API in the future, so if I find anything wrong I send a patch to fix. Thank you and I am sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment