New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20 mBTC Bounty - Refactor xchange-mtgox polling V2 module #273

Closed
timmolter opened this Issue Jan 24, 2014 · 6 comments

Comments

Projects
None yet
2 participants
@timmolter
Member

timmolter commented Jan 24, 2014

Rules for bounties and the explanation of the refactor can be found here: #270

Classes that need to be split:

MtGoxAccountService
MtGoxMarketDataService
MtGoxTradeService

Relevant example classes should also be updated to show both raw and generic polling functions

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 3, 2014

@gnandiga

This comment has been minimized.

Show comment
Hide comment
@gnandiga

gnandiga Feb 3, 2014

Tim,

I have refactored MtGoxAccountService. I think, I followed the instructions in #270. Can you take look at my commit and tell me if I am going in the right direction: gnandiga@c14af59

gnandiga commented Feb 3, 2014

Tim,

I have refactored MtGoxAccountService. I think, I followed the instructions in #270. Can you take look at my commit and tell me if I am going in the right direction: gnandiga@c14af59

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 3, 2014

@timmolter

This comment has been minimized.

Show comment
Hide comment
@timmolter

timmolter Feb 3, 2014

Member

@gnandiga Looks really good!

Member

timmolter commented Feb 3, 2014

@gnandiga Looks really good!

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 3, 2014

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 3, 2014

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 3, 2014

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 4, 2014

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 4, 2014

timmolter added a commit that referenced this issue Feb 4, 2014

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 4, 2014

timmolter added a commit that referenced this issue Feb 4, 2014

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 4, 2014

timmolter added a commit that referenced this issue Feb 4, 2014

@timmolter

This comment has been minimized.

Show comment
Hide comment
@timmolter

timmolter Feb 4, 2014

Member

Just putting the Bitcoin address here from pull request: #287

112LnfRzmA6AMU5i6SHPCGpjM3Ya5pBVLb

Member

timmolter commented Feb 4, 2014

Just putting the Bitcoin address here from pull request: #287

112LnfRzmA6AMU5i6SHPCGpjM3Ya5pBVLb

@timmolter

This comment has been minimized.

Show comment
Hide comment
@timmolter

timmolter Feb 4, 2014

Member

Bounty paid to 112LnfRzmA6AMU5i6SHPCGpjM3Ya5pBVLb. Thanks for your work! I added you as a contributor here as well: https://github.com/timmolter/XChange/wiki

Member

timmolter commented Feb 4, 2014

Bounty paid to 112LnfRzmA6AMU5i6SHPCGpjM3Ya5pBVLb. Thanks for your work! I added you as a contributor here as well: https://github.com/timmolter/XChange/wiki

@timmolter timmolter closed this Feb 4, 2014

@timmolter

This comment has been minimized.

Show comment
Hide comment
@timmolter

timmolter Feb 4, 2014

Member

@gnandiga Where did you find out about this bounty? I posted it in several places.

Member

timmolter commented Feb 4, 2014

@gnandiga Where did you find out about this bounty? I posted it in several places.

@gnandiga

This comment has been minimized.

Show comment
Hide comment
@gnandiga

gnandiga Feb 4, 2014

I found it on coinality.com.

gnandiga commented Feb 4, 2014

I found it on coinality.com.

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment