Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
25 mBTC Bounty - Refactor xchange-bitstamp module #279
Rules for bounties and the explanation of the refactor can be found here: #270
Classes that need to be split:
Relevant example classes should also be updated to show both raw and generic polling functions
I have started to work on BitstampAccountService
Let me know what should be done here?
When they write about Bitstamp on the site it is considered one word (https://www.bitstamp.net/news/), so I think it should be left as is.
The raw service should return a boolean true and the generic service should continue to return "true".
Do all authenticated api calls require a verified account?...After your done with the demos, just let me know which ones need it and I can test them with my verified account. Also, I don't remember it being too much trouble to get a verified account, just a photo id and proof of residence.
Can you give me an example JSON response for https://www.bitstamp.net/api/bitcoin_withdrawal/
I created a BitstampGenericResponse as, we were not parsing the error that was sent in the body and throwing a JSON parse exception.
I want to create associated response class.
Looks like it just returns true/false:
21:00:27.755 [default] [main] DEBUG si.mazi.rescu.HttpTemplate - Executing POST request at https://www.bitstamp.net/api/bitcoin_withdrawal/
Does the parse exception return that same body string '"error": "User not verified"? If not I think it would be better to do a custom deserializer that returns something like BitstampCancelResponse or maybe just a Boolean and during deserialization check for an "error" entry and if it exists throw an ExchangeException with the message body.
see https://github.com/timmolter/XChange/blob/develop/xchange-kraken/src/main/java/com/xeiam/xchange/kraken/dto/marketdata/KrakenOrder.java to get an idea of how to implement a JsonDeserializer.
referenced this issue
Feb 6, 2014
added a commit
Feb 7, 2014
@gnandiga For future reference, there is a code formatting file for the XChange project here: https://github.com/timmolter/XChange/wiki/New-Implementation-Best-Practices
Your code looks really good. I made some minor changes.
@jamespedwards42 Would you be willing to test the authenticated api calls?