25 mBTC Bounty - Refactor xchange-btce V3 module #294

Closed
timmolter opened this Issue Feb 5, 2014 · 14 comments

Comments

Projects
None yet
3 participants
@timmolter
Member

timmolter commented Feb 5, 2014

Rules for bounties and the explanation of the refactor can be found here: #270

Classes that need to be split:

BTCEAccountService
BTCEMarketDataService
BTCETradeService

Relevant example classes should also be updated to show both raw and generic polling functions

@br0x

This comment has been minimized.

Show comment
Hide comment
@br0x

br0x Feb 12, 2014

Contributor

Can take care

Contributor

br0x commented Feb 12, 2014

Can take care

@ObsessiveOrange

This comment has been minimized.

Show comment
Hide comment
@ObsessiveOrange

ObsessiveOrange Feb 13, 2014

Contributor

Hmm. I'm rather new to both github and java, but since I used the Xchange library in some of my programs, I'd like to contribute back. Sending pull request now.

Please do check through the changes I've made. I'm not too sure if it's what you're looking for. It's my very first project both in github and maven, so please be nice :) Comments or pointers for future reference would be great.

Contributor

ObsessiveOrange commented Feb 13, 2014

Hmm. I'm rather new to both github and java, but since I used the Xchange library in some of my programs, I'd like to contribute back. Sending pull request now.

Please do check through the changes I've made. I'm not too sure if it's what you're looking for. It's my very first project both in github and maven, so please be nice :) Comments or pointers for future reference would be great.

@br0x

This comment has been minimized.

Show comment
Hide comment
@br0x

br0x Feb 13, 2014

Contributor

Errr... what about two days rule?

Contributor

br0x commented Feb 13, 2014

Errr... what about two days rule?

@ObsessiveOrange

This comment has been minimized.

Show comment
Hide comment
@ObsessiveOrange

ObsessiveOrange Feb 13, 2014

Contributor

oh. my bad. didn't notice that.

@timmolter give br0x the BTC, I'd just like some comments and feedback, if that's ok?

Contributor

ObsessiveOrange commented Feb 13, 2014

oh. my bad. didn't notice that.

@timmolter give br0x the BTC, I'd just like some comments and feedback, if that's ok?

@br0x

This comment has been minimized.

Show comment
Hide comment
@br0x

br0x Feb 13, 2014

Contributor

I mean, what about my work I spent for the last day... and almost finished

Contributor

br0x commented Feb 13, 2014

I mean, what about my work I spent for the last day... and almost finished

@ObsessiveOrange

This comment has been minimized.

Show comment
Hide comment
@ObsessiveOrange

ObsessiveOrange Feb 13, 2014

Contributor

Sorry about that. Kinda new here, and overlooked that. Got a little excited and trigger happy, i guess. But the reward's yours so that's not wasted work.

Contributor

ObsessiveOrange commented Feb 13, 2014

Sorry about that. Kinda new here, and overlooked that. Got a little excited and trigger happy, i guess. But the reward's yours so that's not wasted work.

@timmolter

This comment has been minimized.

Show comment
Hide comment
@timmolter

timmolter Feb 13, 2014

Member

@ObsessiveOrange I'll check your pull request and give comments, which you can use for issue #297 as claimed by you.

Member

timmolter commented Feb 13, 2014

@ObsessiveOrange I'll check your pull request and give comments, which you can use for issue #297 as claimed by you.

@timmolter

This comment has been minimized.

Show comment
Hide comment
@timmolter

timmolter Feb 13, 2014

Member

@br0x make sure pull in the latest changes to the develop branch, as there have been quite a few refactorings.

Member

timmolter commented Feb 13, 2014

@br0x make sure pull in the latest changes to the develop branch, as there have been quite a few refactorings.

@timmolter

This comment has been minimized.

Show comment
Hide comment
@timmolter

timmolter Feb 14, 2014

Member

Done. PR here: #313
Will pay bounty when address is provided on this issue.

Member

timmolter commented Feb 14, 2014

Done. PR here: #313
Will pay bounty when address is provided on this issue.

@timmolter timmolter closed this Feb 14, 2014

@br0x

This comment has been minimized.

Show comment
Hide comment
@br0x

br0x Feb 14, 2014

Contributor

api keys that I provided for demo code are for new btce account I created. It has no funds, so safe to left privilegies as is

Contributor

br0x commented Feb 14, 2014

api keys that I provided for demo code are for new btce account I created. It has no funds, so safe to left privilegies as is

@timmolter

This comment has been minimized.

Show comment
Hide comment
@timmolter

timmolter Feb 14, 2014

Member

ok.

Member

timmolter commented Feb 14, 2014

ok.

@br0x

This comment has been minimized.

Show comment
Hide comment
@br0x

br0x Feb 15, 2014

Contributor

Ok, I managed to recover my wallet.
Address is 1BTC4brox2pd14QubXGsXwarp9zV9tc8CZ

Contributor

br0x commented Feb 15, 2014

Ok, I managed to recover my wallet.
Address is 1BTC4brox2pd14QubXGsXwarp9zV9tc8CZ

@timmolter

This comment has been minimized.

Show comment
Hide comment
@br0x

This comment has been minimized.

Show comment
Hide comment
@br0x

br0x Feb 15, 2014

Contributor

Thank you!

Contributor

br0x commented Feb 15, 2014

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment