Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Widget "widget_verkehrsinfo.js" #185

Open
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@paul179
Copy link
Contributor

commented Dec 24, 2016

please add new Widget for Modul Verkehrsinfo

new Widget "widget_verkehrsinfo.js"
please add new Widget for Modul Verkehrsinfo
@knowthelist

This comment has been minimized.

Copy link
Owner

commented Dec 24, 2016

Thanks for your contribution. But a few things have to be changed, before I can merge this new widget.

  • it is always a bad idea to use a sleep function for wasting time. See javascripts setTimeout function to postpone calls. But is it really necessary?
  • update function : dev can not be "*". Why this if part?
Update widget_verkehrsinfo.js
Hello,

> •it is always a bad idea to use a sleep function for wasting time. See javascripts setTimeout function to postpone calls. But is it really necessary?

please see
https://forum.fhem.de/index.php/topic,55118.msg544555.html#msg544555 and I have this delete

> •update function : dev can not be "*". Why this if part?
for Problem see link I have this copy from widget calview, I have this changed.
@paul179

This comment has been minimized.

Copy link
Contributor Author

commented Dec 24, 2016

Hello,

•it is always a bad idea to use a sleep function for wasting time. See javascripts setTimeout function to postpone calls. But is it really necessary?

please see
https://forum.fhem.de/index.php/topic,55118.msg544555.html#msg544555 and I have this delete

•update function : dev can not be "*". Why this if part?
for Problem see link I have this copy from widget calview, I have this changed.

@knowthelist

This comment has been minimized.

Copy link
Owner

commented Dec 24, 2016

Normally a delay is not necessary. There must be a conceptual failure. Via long poll for each reading updated in FHEM, the update function get called.

@paul179

This comment has been minimized.

Copy link
Contributor Author

commented Dec 24, 2016

I understand what I should do? I have the Code changed!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.