Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will Google+ API Shutdown affect this bundle #161

Closed
ghost opened this issue Jan 31, 2019 · 6 comments
Closed

Will Google+ API Shutdown affect this bundle #161

ghost opened this issue Jan 31, 2019 · 6 comments

Comments

@ghost
Copy link

@ghost ghost commented Jan 31, 2019

Not an issue, just an inquiry,

Google is shutting down the Google+ API on March 7, 2019. Will this bundle be affected by this change? https://developers.google.com/+/api-shutdown

@weaverryan
Copy link
Member

@weaverryan weaverryan commented Jan 31, 2019

I have no idea :). It won't affect this bundle, but it may affect the actual library that talks to Google's OAuth. Here's a commit I found on that library: thephpleague/oauth2-google@8ce837d

Cheers!

@fdiedler
Copy link

@fdiedler fdiedler commented Feb 11, 2019

If anyone has the answer to this question, please tell :)

But, we will know the answer on March 7, 2019.

Thanks

@weaverryan
Copy link
Member

@weaverryan weaverryan commented Feb 11, 2019

As long as you're using version 3.0 or higher of thephpleague/oauth2-google, I think you're fine - as they have removed the old functionality in that version (so there is now way to use that version and get things working by relying on the functionality that will be removed).

@ghost
Copy link
Author

@ghost ghost commented Feb 11, 2019

I'm not very familiar with Google Sign in API, but I think you guys maybe should change some parameter names. As I see, they are dropping the names {google-app-id} and {google-app-secret} and using [OpenID Connect][openid-connect].

This package uses [OpenID Connect][openid-connect] to authenticate users with
Google accounts.

also

To use this package, it will be necessary to have a Google client ID and client
secret. These are referred to as {google-client-id} and {google-client-secret}
in the documentation.

Excuse me if i'm mistaken!

@weaverryan
Copy link
Member

@weaverryan weaverryan commented Feb 14, 2019

As I see, they are dropping the names {google-app-id} and {google-app-secret} and using [OpenID Connect][openid-connect].

Yes, but both ultimately are mapped to the clientId and clientSecret params passed to the library - thephpleague/oauth2-google@8ce837d#diff-04c6e90faac2675aa89e2176d2eec7d8R57

Basically, I think that a user of the thephpleague/oauth2-google library may need to make some changes to get v 3.0 to work with openid - getting a Google client ID / secret etc. Then you will use these values for the client_id and client_secret params in this bundle. This bundle doesn't have anything about google-app-id or anything similar - you can see all the options here:

public function getProviderOptions(array $config)
{
$options = [
'clientId' => $config['client_id'],
'clientSecret' => $config['client_secret'],
];
if ($config['access_type']) {
$options['accessType'] = $config['access_type'];
}
if ($config['hosted_domain']) {
$options['hostedDomain'] = $config['hosted_domain'];
}
if (!empty($config['user_fields'])) {
$options['userFields'] = $config['user_fields'];
}
if (!empty($config['use_oidc_mode'])) {
$options['useOidcMode'] = $config['use_oidc_mode'];
}
return $options;
}

Cheers!

@fdiedler
Copy link

@fdiedler fdiedler commented Feb 15, 2019

I found this link :
thephpleague/oauth2-google#63

It looks like everything is okay and the bundle has been updated but not really sure.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.