Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to add a lot more providers! #7

Open
weaverryan opened this issue Jan 25, 2016 · 10 comments
Open

We need to add a lot more providers! #7

weaverryan opened this issue Jan 25, 2016 · 10 comments

Comments

@weaverryan
Copy link
Member

@weaverryan weaverryan commented Jan 25, 2016

We should support as many providers as possible, and there are many: https://github.com/thephpleague/oauth2-client/blob/master/README.PROVIDERS.md

  • Google #3
  • Instagram
  • LinkedIn #9
  • VK #10 (was reverted)

... and I would accept any other additions

@javiereguiluz
Copy link

@javiereguiluz javiereguiluz commented Jan 25, 2016

Wouldn't Google, Facebook, Twitter, LinkedIn, Instagram and GitHub cover 99% of the needs? I'd say those are enough for the first version of the bundle.

@Babacooll
Copy link

@Babacooll Babacooll commented Jan 25, 2016

I can manage to do the Twitch provider if nobody has planed to do it.

@fatihkahveci
Copy link
Contributor

@fatihkahveci fatihkahveci commented Jan 25, 2016

If we can add Yahoo and Yandex provider too it will be cool for first release.

@weaverryan
Copy link
Member Author

@weaverryan weaverryan commented Jan 26, 2016

@javiereguiluz I agree, I won't wait for providers to make a release. I'm not afraid of making many more releases after as we add more providers.

@Babacooll I've never used Twitch, but that would be rad!

@kbond
Copy link

@kbond kbond commented Feb 23, 2016

How could Twitter be added? It is my understanding it is oauth1.

@weaverryan
Copy link
Member Author

@weaverryan weaverryan commented Feb 23, 2016

Ah yea, we can't support Twitter. I'm not opposed to supporting OAuth1 - obviously Twitter makes a good case for it, but I don't know if it's the only one. I also don't know if it'll be a huge pain to try to integrate it in cleanly (i.e. hacky), or if it could be done cleanly. There is an OAuth1 library from the PHP league... and perhaps we should not support it, but mention something in the README (e.g. use this OAuth1 library directly if you need something like Twitter). Afterall, this bundle is mostly a think integration layer.

@jmolivas
Copy link

@jmolivas jmolivas commented Jul 14, 2016

@kbond @weaverryan I found a project for Twitter https://github.com/Maslosoft/oauth2-twitter but is not working properly.

I added an issue on the main repo Maslosoft/oauth2-twitter#1

@pmaselkowski
Copy link

@pmaselkowski pmaselkowski commented Jul 19, 2016

Hello,
Maslosoft/oauth2-twitter project is on hold until twitter fully implements oauth2. To be even worse, if you need user email for oauth1, you need to ask twitter for permission (via support request), or email will not be provided.

@weaverryan
Copy link
Member Author

@weaverryan weaverryan commented Jan 6, 2017

fwiw - here's a quick answer for others that find this on how you could use the phpleage oauth1 library in Symfony to connect with Twitter: http://knpuniversity.com/blog/KnpUOAuth2ClientBundle#comment-3086507464

@proArtex
Copy link

@proArtex proArtex commented Apr 3, 2018

Vote for twitter provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.