Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

README.md: Add troubleshooting for use with RTIC #183

Merged
merged 1 commit into from Apr 25, 2021

Conversation

davidlattimore
Copy link
Contributor

Additional context:
knurling-rs/defmt#450

Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me.

One nit: Can you add some more lines to make the code snippets more "copy-pastable"? For the first one it's probably only some import, for the second maybe some type information for ctx.

@davidlattimore
Copy link
Contributor Author

I expanded the second one to include the signature of the init function, which includes the ctx argument. init and idle come from the RTIC procedural macro. I could include a full RTIC program, but that might be a bit too much?

@Urhengulas
Copy link
Member

I could include a full RTIC program, but that might be a bit too much?

Yes, that would be too much. Someone facing this problem likely knows the structs, I guess.

Looks good to me now. Thanks a lot!

Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors bors bot merged commit e8be32a into knurling-rs:main Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants