Fix process crash for unsupported protocol #50

Closed
wants to merge 1 commit into
from

2 participants

@sthadka

Fix for the process crash:

CRASH REPORT Process <0.18299.93> with 0 neighbours exited with reason: bad argument in call to erlang:node({error,not_supported}) in elli_request:is_ref_alive/1 line 144 in gen_server:terminate/6 line 747
@knutin
Owner

I would be really curious to know how the input got to be {error, not_supported}. As the input to this function should only come from the #req.pid, maybe the source is messed up. It would be best to fix the root of the problem.

@sthadka

It turns out that we had a client trying to connect with HTTP 1.0, the case for which was not handled by us. The fix will no longer hit this corner of elli anymore.

The patch might still be useful for applications does not explicitly check the protocol version before passing on the request to elli.

@knutin knutin closed this Jan 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment