Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scim json format #151

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Support scim json format #151

merged 1 commit into from
Mar 15, 2023

Conversation

caryyu
Copy link
Contributor

@caryyu caryyu commented Mar 15, 2023

As I'm recently starting to integrate the Okta SCIM into our system, I've discovered this lib doesn't provide a flexible way to extend the content-type for SCIM-JSON that the protocol asks for, here comes the proposal/workaround.

BTW: Maybe another better way is to expose the extension of jsonTypes outside the code :)

Here's the protocol detail: https://www.rfc-editor.org/rfc/rfc7644#section-3.12

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fengmk2 fengmk2 merged commit 49d36ec into koajs:master Mar 15, 2023
fengmk2 pushed a commit that referenced this pull request Mar 15, 2023
@fengmk2
Copy link
Member

fengmk2 commented Mar 15, 2023

4.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants