New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs, don't advise using --harmony or harmonica anymore #65

Closed
wants to merge 1 commit into
base: next
from

Conversation

2 participants
@mgol

mgol commented Mar 31, 2017

Node.js 7.6.0 and newer support async/await natively and older versions
have serious memory leaks so it's better to not rely on --harmony. If running
Koa in an older Node.js version is desired, it's better to transpile async/await
rather than rely on a buggy implementation.

@shellscape

This comment has been minimized.

Show comment
Hide comment
@shellscape

shellscape Mar 31, 2017

Contributor

thank you for the PR, but I disagree with your assessment. some folks have no choice as to the version of node they run.

Contributor

shellscape commented Mar 31, 2017

thank you for the PR, but I disagree with your assessment. some folks have no choice as to the version of node they run.

@shellscape shellscape closed this Mar 31, 2017

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Mar 31, 2017

I realize some people don't have a choice of a Node version they run on. I'm just saying for those people it's usually better to transpile in such a case instead of relying on a buggy implementation. Node.js older than 7.6 has memory leaks in its async/await implementation (see nodejs/node#9339); using Babel will avoid that.

One can use babel-register to make it quite seamless. What do you think about recommending that instead?

mgol commented Mar 31, 2017

I realize some people don't have a choice of a Node version they run on. I'm just saying for those people it's usually better to transpile in such a case instead of relying on a buggy implementation. Node.js older than 7.6 has memory leaks in its async/await implementation (see nodejs/node#9339); using Babel will avoid that.

One can use babel-register to make it quite seamless. What do you think about recommending that instead?

@shellscape

This comment has been minimized.

Show comment
Hide comment
@shellscape

shellscape Mar 31, 2017

Contributor

well babel-register isn't recommended for production use, so I don't think that's a good recommendation. And --harmony flags are considered experimental/unstable and preview, which means not for production use. I think it's reasonable to assume that anyone dabbling with an unstable harmony feature understands that it's unstable. I'd be open to language that points out (gently) that it's recommended to upgrade, but I don't want to mislead people who are stuck on that version and want to play with the features.

Contributor

shellscape commented Mar 31, 2017

well babel-register isn't recommended for production use, so I don't think that's a good recommendation. And --harmony flags are considered experimental/unstable and preview, which means not for production use. I think it's reasonable to assume that anyone dabbling with an unstable harmony feature understands that it's unstable. I'd be open to language that points out (gently) that it's recommended to upgrade, but I don't want to mislead people who are stuck on that version and want to play with the features.

@shellscape shellscape reopened this Mar 31, 2017

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Mar 31, 2017

mgol commented Mar 31, 2017

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Mar 31, 2017

One more question: should koa-hbs still use harmonica itself? Since it's tested in latest v7 it would work without it as well and there's always a slight risk in using --harmony-* flags.

I can prepare a PR once I know what's your take here.

mgol commented Mar 31, 2017

One more question: should koa-hbs still use harmonica itself? Since it's tested in latest v7 it would work without it as well and there's always a slight risk in using --harmony-* flags.

I can prepare a PR once I know what's your take here.

Update docs, don't advise using --harmony or harmonica anymore
Node.js 7.6.0 and newer support async/await natively and older versions
have serious memory leaks so it's better to not rely on --harmony. If running
Koa in an older Node.js version is desired, it's better to transpile async/await
rather than rely on a buggy implementation.
@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Nov 15, 2017

PR updated. Does that look better?

mgol commented Nov 15, 2017

PR updated. Does that look better?

@shellscape

This comment has been minimized.

Show comment
Hide comment
@shellscape

shellscape Jan 13, 2018

Contributor

I'm gonna step the module in a different direction and compile down to Node 6 support, which will result in removing all of the documentation about running with harmony. In the end I think this will be more beneficial to all.

Contributor

shellscape commented Jan 13, 2018

I'm gonna step the module in a different direction and compile down to Node 6 support, which will result in removing all of the documentation about running with harmony. In the end I think this will be more beneficial to all.

@shellscape shellscape closed this Jan 13, 2018

@mgol mgol deleted the mgol:docs branch Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment