response.redirect: extract special-cased back, fixes #904#1115
response.redirect: extract special-cased back, fixes #904#1115jonathanong merged 2 commits intokoajs:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1115 +/- ##
==========================================
- Coverage 99.61% 99.47% -0.14%
==========================================
Files 5 7 +2
Lines 520 575 +55
Branches 147 165 +18
==========================================
+ Hits 518 572 +54
- Misses 2 3 +1 ☔ View full report in Codecov by Sentry. |
|
I'm assuming this is a travis-cache thingie that fails, can't reproduce it locally. $ git rev-parse --abbrev-ref HEAD
refactor-back
$ node -v
v9.3.0
$ npm -v
5.6.0
$ npm view koa version
2.4.1
$ npm t
# abbreviated jest output
Test Suites: 66 passed, 66 total
Tests: 298 passed, 298 total
Snapshots: 0 total
Time: 2.265s
Ran all test suites. |
|
👍 let's add this as a feature + deprecation message, then a separate PR to remove it in the next major version |
fl0w
force-pushed
the
refactor-back
branch
3 times, most recently
from
cad890c to
ac6bef5
Compare
|
@jonathanong updated, and should be safe as a semver-minor merge. Just take a quick look at the deprecation message before doing so. |
3imed-jaberi
left a comment
3imed-jaberi
left a comment
There was a problem hiding this comment.
LGTM, I believe that should be merged this PR 🚀
kevinpeno
force-pushed
the
refactor-back
branch
2 times, most recently
from
a231946 to
aa5f75b
Compare
kevinpeno
force-pushed
the
refactor-back
branch
from
aa5f75b to
ad03d65
Compare
|
@jonathanong should be gtg. Codecov is bitching, but the related missed line is not related to the changes made in this PR. It is likely the methods added to this PR pushed the file over its limits. I think we should ignore it for this PR. |
|
I couldn't see this update because this was done om my "stolen" account :) Great to see this merged. |
…oa v3
Koa v3 removes ctx.redirect('back') and replaces it with ctx.back(fallbackUrl).
This polyfill intercepts ctx.redirect('back') calls and converts them to use
the Referer header with a fallback URL, maintaining backward compatibility
with the 34 existing usages in the codebase.
- Add helpers/koa-redirect-back-polyfill.js middleware
- Apply polyfill to web, api, caldav, and carddav servers via hookBeforeSetup
- No changes needed to existing controller code
- Supports localized fallback URLs via ctx.state.l()
@see https://github.com/koajs/koa/releases/tag/v3.0.0
@see koajs/koa#1115
6 participants
The simple solution to drop special-cased
'back'inresponse.redirect.I can't label but should be labeled as version-major.
This PR does not make use of Symbol as purposed in #904.
Edit
If this solution is acceptable, a deprecation should be added to Koa 2 on
'back'use.