feat: replace cache-content-type with mime-types directly#1886
Merged
3imed-jaberi merged 2 commits intomasterfrom Jun 6, 2025
Merged
feat: replace cache-content-type with mime-types directly#18863imed-jaberi merged 2 commits intomasterfrom
3imed-jaberi merged 2 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1886 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 9 9
Lines 2046 2048 +2
=======================================
+ Hits 2044 2046 +2
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@jonathanong I’ve removed cache-content-type because it’s not in sync with the latest mime-types. I think we should rely directly on the upstream mime-types package instead. If you’re on board, we can move forward with this PR. Otherwise, happy to close it! |
Member
|
@fengmk2 @dead-horse why do we need to cache the content type? I think all the mime types are already in memory |
2d8d15c to
c32e378
Compare
Member
|
@3imed-jaberi my preference would be to just remove caching entirely |
Member
Author
|
@jonathanong done 🚀 ! |
Member
|
Cache is no longer needed +1 |
jonathanong
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist