New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Assets Dependency system #110

Merged
merged 82 commits into from Oct 31, 2013

Conversation

Projects
None yet
2 participants
@nsams
Copy link
Member

nsams commented Sep 25, 2013

//own cache for encoded contents, not using Kwf_Assets_Cache as we don't need to in two-level cache
$cacheId = 'as_'.str_replace(array(':', '/'), '_', $url).'_'.$encoding;
$ret = Kwf_Cache_SimpleStatic::fetch($cacheId);
$ret = false;

This comment has been minimized.

@fraxachun

fraxachun Oct 11, 2013

Contributor

Line should be removed for production

@@ -0,0 +1,15 @@
<?php
class Kwf_Assets_Dependency_MimeTypeFilterItrator extends FilterIterator

This comment has been minimized.

@fraxachun

fraxachun Oct 11, 2013

Contributor

Iterator instead of Itrator

@fraxachun fraxachun closed this Oct 11, 2013

@fraxachun fraxachun reopened this Oct 11, 2013

@fraxachun

This comment has been minimized.

Copy link
Contributor

fraxachun commented Oct 24, 2013

Kwf/Assets/Dependency/Component.php is empty

@fraxachun

This comment has been minimized.

Copy link
Contributor

fraxachun commented Oct 25, 2013

Kwf_Assets_Modernizr_Dependency_Feature isn't used at all?

}
}
private function _getRecursiveChildClasses($class, $dependencyName, &$processedComponents = array())

This comment has been minimized.

@fraxachun

fraxachun Oct 25, 2013

Contributor

$dependencyName is never used

}
$DirIterator = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($path));
foreach ($DirIterator as $file) {
if (!preg_match('#/\\.svn/#', $file->getPathname())

This comment has been minimized.

@fraxachun

fraxachun Oct 25, 2013

Contributor

Why not all hidden files

nsams added some commits Oct 29, 2013

save childRows earlier
this allows accessing saved child rows in _afterInsert, not only
_afterSave - because _afterSave is called after _afterInsert
move duplicate files into own dependency
the new dependency system doesn't support that anymore
add check for duplicate files
if duplicate is found throw exception
set created dependency before loading child dependencies
avoid endless recursions if dependency depends (indirectly) on itself
move form dependencies into dependencies.ini
fixes problem with star dependency

nsams added some commits Sep 26, 2013

move recursive resolving dependencies into Provider
for that Provider needs a reference to ProviderList which is set now

this makes it possible to implement more complicated dependencies like needed for modernizr
rename classes for better structure
- iterators in own subfolder
- Package not in Dependency, as it's not a dependency
- also moved UrlResolvableInterface
remove Media_Headline feature
- isn't compatible with new assets system
- shouldn't be used anyway - replace with webfonts or cufon
filter all hidden files using a (new) FilterIterator
also add some api docs for FileExtension filter and use that one

nsams added a commit that referenced this pull request Oct 31, 2013

Merge pull request #110 from nsams/assets-dep
New Assets Dependency system

@nsams nsams merged commit c007d03 into koala-framework:master Oct 31, 2013

1 check passed

default The Travis CI build passed
Details

@nsams nsams deleted the nsams:assets-dep branch Oct 31, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment