New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render a link-tag instead of a componentLink #728

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
4 participants
@jamesricky
Contributor

jamesricky commented Feb 13, 2018

Previously the componentLink would render a link that would use
the componentName of the target as the link text.

@jamesricky jamesricky requested review from nsams, fraxachun and kaufmo Feb 13, 2018

@kaufmo

kaufmo approved these changes Feb 13, 2018

@nsams

This comment has been minimized.

Member

nsams commented Feb 13, 2018

der parent dieser komponente macht exakt das gleiche: https://github.com/koala-framework/koala-framework/blob/4.6/Kwc/Basic/LinkTag/Abstract/Mail.html.tpl

könntest du das template einfach löschen?

und bei allen newsletteränderungen das eigene newsletter repo beachten....

@kaufmo

this will not work, abstract linktag only works with data key, here you use target key

@jamesricky jamesricky requested review from kaufmo and fraxachun Feb 14, 2018

@kaufmo

kaufmo approved these changes Feb 14, 2018

@@ -1 +1 @@
{{ target.getAbsoluteUrl() }}

This comment has been minimized.

@nsams

nsams Feb 15, 2018

Member

des funktioniert dann nicht mehr

@nsams

nsams approved these changes Feb 15, 2018

Render a link-tag instead of a componentLink
Previously the componentLink would render a link that would use
the componentName of the target as the link text.

The absolute url is also not required in the text mail.

@jamesricky jamesricky merged commit 6282a72 into 4.6 Feb 15, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@jamesricky jamesricky deleted the fix-mail-linktag branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment