New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki: toolbar_position Properrty #537

Closed
enrico28 opened this Issue Dec 4, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@enrico28

enrico28 commented Dec 4, 2017

The Property toolbar_position is present in the page 1.04 Paging
and in the page 1.09 Submit and reset button, but it refers to the
Property rows_counter. It would be useful to be able to place the
reset button in other positions.

Cheers!

@koalyptus

This comment has been minimized.

Show comment
Hide comment
@koalyptus

koalyptus Dec 5, 2017

Owner

tx @enrico28, unfortunate copy&paste. I have updated the wiki, so that it is clear reset button can be placed in other positions, altough toolbar_position option is badly named here and very confusing.
Just realised the btn_reset wasn't refactored into a structured literal object like the rest:

var tfConfig = {
  btn_reset: {
    ...
  }
};

I will refactor this in the next release(s).
Cheers

Owner

koalyptus commented Dec 5, 2017

tx @enrico28, unfortunate copy&paste. I have updated the wiki, so that it is clear reset button can be placed in other positions, altough toolbar_position option is badly named here and very confusing.
Just realised the btn_reset wasn't refactored into a structured literal object like the rest:

var tfConfig = {
  btn_reset: {
    ...
  }
};

I will refactor this in the next release(s).
Cheers

@enrico28

This comment has been minimized.

Show comment
Hide comment
@enrico28

enrico28 Dec 5, 2017

Thank you a lot!!!

Maybe even 1.04 Paging needs an update:

var tfConfig = {
rows_counter: {
toolbar_position: 'left'
}
};

->

var tfConfig = {
paging: {
toolbar_position: 'left'
}
};

enrico28 commented Dec 5, 2017

Thank you a lot!!!

Maybe even 1.04 Paging needs an update:

var tfConfig = {
rows_counter: {
toolbar_position: 'left'
}
};

->

var tfConfig = {
paging: {
toolbar_position: 'left'
}
};

@koalyptus

This comment has been minimized.

Show comment
Hide comment
@koalyptus

koalyptus Dec 8, 2017

Owner

Hey @enrico28 I've just refactored the btn_reset options (v0.6.8) and corrected the paging wiki.

Owner

koalyptus commented Dec 8, 2017

Hey @enrico28 I've just refactored the btn_reset options (v0.6.8) and corrected the paging wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment