New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State restore from 'hash' does not work with checklist filter with regexp as values #539

Closed
maciex opened this Issue Dec 6, 2017 · 6 comments

Comments

2 participants
@maciex

maciex commented Dec 6, 2017

State restore from 'hash' does not work with checklist filter with regexp as values

Reproduction steps:

  1. Create table filtering for checklist column with custom options as below. Enable state saving as 'hash':
custom_options: {
    cols:[4],
    texts: [
        [
            'AIX','ALL''LINUX'
        ]
    ],
    values: [
        [
            'rgx:^AIX$','rgx:^ALL$','rgx:^LINUX$'
        ]
    ],
    sorts: [false]
}
  1. Select 'ALL' in the column filter and try to reuse the URL in a new browser window

Expected behavior:
'ALL' item in the checklist is selected

Observed behavior:
When one enters the URL with saved state (http://localhost:8000/patches.html#%7B%22col_4%22%3A%7B%22flt%22%3A%5B%22rgx%3A%5EALL%24%22%5D%7D%7D) the item 'ALL' is not selected.

Workaround:
If one enters the URL http://localhost:8000/patches.html#{%22col_4%22%3A{%22flt%22%3A[%22ALL%22]}} it works. So I think that instead of the items value rgx:^ALL$ the item's text 'ALL' is used to do the checklist selection, but the values are encoded in the URL.

TableFilter version: v0.6.2
Browser and version: Firefox 57.0
OS and version: Fedora 27

Additional information:

  • Problem started happening recently, didn't happen in an older version of
    TableFilter: No
  • Problem can be reliably reproduced, doesn't happen randomly: Yes

@koalyptus koalyptus added the bug label Dec 7, 2017

@koalyptus

This comment has been minimized.

Show comment
Hide comment
@koalyptus

koalyptus Dec 7, 2017

Owner

Tx @maciex,
For pointing this out, 👍 for using the template

Owner

koalyptus commented Dec 7, 2017

Tx @maciex,
For pointing this out, 👍 for using the template

@koalyptus koalyptus added this to In Progress in Refactoring/tech debt/bugs Dec 7, 2017

@koalyptus koalyptus moved this from In Progress to In QA in Refactoring/tech debt/bugs Dec 7, 2017

@koalyptus

This comment has been minimized.

Show comment
Hide comment
@koalyptus

koalyptus Dec 7, 2017

Owner

@maciex your fix is now merged and deployed, tx again for contributing.

Owner

koalyptus commented Dec 7, 2017

@maciex your fix is now merged and deployed, tx again for contributing.

@maciex

This comment has been minimized.

Show comment
Hide comment
@maciex

maciex Dec 7, 2017

@koalyptus I'm not sure why I added "fix for # 539" in that pull request...
These problems are not related.

Edit:
Oh wait, you edited that description. Was it mistake?

maciex commented Dec 7, 2017

@koalyptus I'm not sure why I added "fix for # 539" in that pull request...
These problems are not related.

Edit:
Oh wait, you edited that description. Was it mistake?

@koalyptus

This comment has been minimized.

Show comment
Hide comment
@koalyptus

koalyptus Dec 7, 2017

Owner

My bad I thought they were related, ok i'll fix #539 in next releases

Owner

koalyptus commented Dec 7, 2017

My bad I thought they were related, ok i'll fix #539 in next releases

@koalyptus

This comment has been minimized.

Show comment
Hide comment
@koalyptus

koalyptus Dec 10, 2017

Owner

@maciex starting from v0.6.9 the bug you pointed out should be fixed.
Cheers

Owner

koalyptus commented Dec 10, 2017

@maciex starting from v0.6.9 the bug you pointed out should be fixed.
Cheers

@koalyptus koalyptus moved this from TODO to In Progress in Refactoring/tech debt/bugs Dec 10, 2017

@koalyptus koalyptus moved this from In Progress to In QA in Refactoring/tech debt/bugs Dec 10, 2017

@maciex

This comment has been minimized.

Show comment
Hide comment
@maciex

maciex Dec 11, 2017

@koalyptus Works fine. Thank you.

maciex commented Dec 11, 2017

@koalyptus Works fine. Thank you.

@koalyptus koalyptus closed this Dec 12, 2017

@koalyptus koalyptus moved this from In QA to DONE in Refactoring/tech debt/bugs Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment