Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutlierRemover and tests #148

Merged
merged 9 commits into from Jun 28, 2019

Conversation

Projects
None yet
2 participants
@jcshoekstra
Copy link
Contributor

commented May 31, 2019

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #121

New dependencies

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines (flake8)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (also to the readme.md)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added tests to check whether the new feature adheres to the sklearn convention
  • New and existing unit tests pass locally with my changes

If you feel your PR is ready for a review, ping @koaning or @MBrouns

Jelte Hoekstra

@koaning koaning changed the title Add OutlierRemover and tests [WIP] Add OutlierRemover and tests Jun 2, 2019

Jelte Hoekstra and others added some commits Jun 5, 2019

Jelte Hoekstra
Jelte Hoekstra

@jcshoekstra jcshoekstra changed the title [WIP] Add OutlierRemover and tests Add OutlierRemover and tests Jun 14, 2019

@jcshoekstra

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

@koaning
Copy link
Owner

left a comment

I only have minor things that pop to mind here that involve adding some extra tests. Other than that: it looks good, thanks for contributing!

Show resolved Hide resolved tests/test_meta/test_outlier_remover.py Outdated
Show resolved Hide resolved tests/test_meta/test_outlier_remover.py

Jelte Hoekstra added some commits Jun 28, 2019

@koaning koaning merged commit c6cc7f6 into koaning:master Jun 28, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.