From 86e14e1a361dea397b823c6eb4a3358dd077ef6d Mon Sep 17 00:00:00 2001 From: Leszek Date: Thu, 20 Jun 2024 18:53:40 +0200 Subject: [PATCH] replaced almost all mdl-buttons (including @extend) with Button component --- jsapp/js/bemComponents.ts | 2 - .../components/assetsTable/assetsTable.scss | 16 -- jsapp/js/components/common/modal.scss | 39 ++++ jsapp/js/components/map.scss | 39 ---- jsapp/js/components/mapSettings.es6 | 8 +- .../components/permissions/sharingForm.scss | 4 - .../reports/questionGraphSettings.es6 | 16 +- .../reports/reportStyleSettings.es6 | 15 +- jsapp/js/components/reports/reports.scss | 1 + jsapp/js/editorMixins/cascadeMixin.es6 | 16 +- jsapp/js/editorMixins/editableForm.es6 | 186 ++++++++++-------- jsapp/scss/components/_kobo.bem.ui.scss | 25 +-- jsapp/scss/components/_kobo.drawer.scss | 4 - jsapp/scss/components/_kobo.form-builder.scss | 177 ++--------------- 14 files changed, 187 insertions(+), 361 deletions(-) diff --git a/jsapp/js/bemComponents.ts b/jsapp/js/bemComponents.ts index 47f557a3a9..d46c88e162 100644 --- a/jsapp/js/bemComponents.ts +++ b/jsapp/js/bemComponents.ts @@ -46,8 +46,6 @@ bem.FormBuilderHeader = makeBem(null, 'form-builder-header'); bem.FormBuilderHeader__row = makeBem(bem.FormBuilderHeader, 'row'); bem.FormBuilderHeader__cell = makeBem(bem.FormBuilderHeader, 'cell'); bem.FormBuilderHeader__item = makeBem(bem.FormBuilderHeader, 'item', 'span'); -bem.FormBuilderHeader__button = makeBem(bem.FormBuilderHeader, 'button', 'button'); -bem.FormBuilderHeader__close = makeBem(bem.FormBuilderHeader, 'close', 'button'); bem.FormMedia = makeBem(null, 'form-media'); bem.FormMedia__title = makeBem(bem.FormMedia, 'title'); diff --git a/jsapp/js/components/assetsTable/assetsTable.scss b/jsapp/js/components/assetsTable/assetsTable.scss index 08dd4384c2..92b9b8bb64 100644 --- a/jsapp/js/components/assetsTable/assetsTable.scss +++ b/jsapp/js/components/assetsTable/assetsTable.scss @@ -70,22 +70,6 @@ $assets-table-hover-bg: colors.$kobo-gray-98; color: colors.$kobo-gray-40; background-color: colors.$kobo-gray-96; height: 40px; - - .mdl-button { - margin-left: 0; - margin-right: 0; - padding-right: 0; - padding-left: 12px; - line-height: 32px; - height: 32px; - min-height: 32px; - - .k-icon { - font-size: 24px; - margin: 0 3px; - float: right; - } - } } .assets-table--MY_LIBRARY, diff --git a/jsapp/js/components/common/modal.scss b/jsapp/js/components/common/modal.scss index 1d5785d730..dc8fffbf66 100644 --- a/jsapp/js/components/common/modal.scss +++ b/jsapp/js/components/common/modal.scss @@ -684,6 +684,45 @@ $modal-custom-header-height: sizes.$x60; gap: 5px; } +// Tab button - styles were copied from the deprecated `mdl-button` +.legacy-modal-tab-button { + text-decoration: none; + text-align: center; + font-weight: normal; + font-size: variables.$base-font-size; + letter-spacing: 0; + margin: 0; + border: none; + vertical-align: middle; + background: transparent; + position: relative; + display: inline-block; + overflow: hidden; + cursor: pointer; + color: colors.$kobo-white; + opacity: 0.7; + border-radius: 0; + border-bottom: 2px solid transparent; + text-transform: uppercase; + height: 50px; + line-height: 50px; + padding: 0 32px; + + &::-moz-focus-inner { + border: 0; + } + + &:hover { + opacity: 1; + color: colors.$kobo-white; + } + + &.legacy-modal-tab-button--active { + opacity: 1; + border-bottom: 2px solid white; + } +} + // TODO: rework all these media queries to mobile first @media screen and (width < 480px) { .table-media-preview-header { diff --git a/jsapp/js/components/map.scss b/jsapp/js/components/map.scss index 45eb710a56..7bb6c97c66 100644 --- a/jsapp/js/components/map.scss +++ b/jsapp/js/components/map.scss @@ -472,45 +472,6 @@ body .leaflet-control-layers, line-height: 20px; } -// Tab button - styles were copied from the deprecated `mdl-button` -.map-modal-tab-button { - text-decoration: none; - text-align: center; - font-weight: normal; - font-size: variables.$base-font-size; - letter-spacing: 0; - margin: 0; - border: none; - vertical-align: middle; - background: transparent; - position: relative; - display: inline-block; - overflow: hidden; - cursor: pointer; - color: colors.$kobo-white; - opacity: 0.7; - border-radius: 0; - border-bottom: 2px solid transparent; - text-transform: uppercase; - height: 50px; - line-height: 50px; - padding: 0 32px; - - &::-moz-focus-inner { - border: 0; - } - - &:hover { - opacity: 1; - color: colors.$kobo-white; - } - - &.active { - opacity: 1; - border-bottom: 2px solid white; - } -} - @include breakpoints.breakpoint(mediumAndUp) { .popover-menu--viewby-menu .popover-menu__toggle { max-width: 340px; diff --git a/jsapp/js/components/mapSettings.es6 b/jsapp/js/components/mapSettings.es6 index 7da013b4f1..c186c9912e 100644 --- a/jsapp/js/components/mapSettings.es6 +++ b/jsapp/js/components/mapSettings.es6 @@ -15,6 +15,7 @@ import { import { dataInterface } from '../dataInterface'; import {userCan} from 'js/components/permissions/utils'; import Button from 'js/components/common/button'; +import cx from 'classnames'; // see kobo.map.marker-colors.scss for styling details of each set const COLOR_SETS = ['a', 'b', 'c', 'd', 'e']; @@ -273,9 +274,10 @@ class MapSettings extends React.Component { var modalTabs = tabs.map(function(tabId, i) { return (