Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix is broken when using translations #2604

Closed
magicznyleszek opened this issue Mar 27, 2020 · 0 comments
Closed

Matrix is broken when using translations #2604

magicznyleszek opened this issue Mar 27, 2020 · 0 comments
Assignees
Labels
bug Things broken and not working as expected high priority To be done soon UI & UX User interface problems and improvements

Comments

@magicznyleszek
Copy link
Member

Description

Having a matrix question and translations generates an unnecessary null translation when saving in Form Builder.

Steps to Reproduce

  1. Create new form using Form Builder
  2. Define a new question using "Question Matrix" (you can leave default values)
  3. Save and close
  4. In Manage Languages modal define default language (e.g. "English (en)") and close the modal
  5. Open form in Form Builder
  6. Don't edit anything, just hit Save and close
  7. Observe Languages list is now "English (en), Unnamed language"

Expected behavior

The null language should not be added.

Additional details

Observed on https://kf.kobotoolbox.org/.

My guess would be to check out the nullifyTranslations/unnullifyTranslations flow and what it does to the matrix type. Probably Matrix has some custom hack on its own.

@magicznyleszek magicznyleszek added bug Things broken and not working as expected UI & UX User interface problems and improvements high priority To be done soon labels Mar 27, 2020
@duvld duvld self-assigned this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things broken and not working as expected high priority To be done soon UI & UX User interface problems and improvements
Projects
None yet
Development

No branches or pull requests

2 participants