Warn before closing Translations table modal #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
A few observations:
I had some earlier comments that I've since erased about the app crashing with a white screen, but that problem is not related to this PR. It's now tracked at #2011. |
Member
Author
|
@jnm I'v added confirm for BACK button and updated some text labels. I also found an easy way to know if there are unsaved changes and only apply BACK confirm then. Do you think it's worthwhile to apply this logic to modal's close/backdrop click? It would be a bit more complex, as the code for closing modal is completely separated from modal's content code. Also: I fixed the error from #2011 |
jnm
approved these changes
Oct 2, 2018
Member
|
@magicznyleszek, I think it's worthwhile but less urgent. Could you create an issue for that and prioritize it as you see fit? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Works on all: Escape key, backdrop click and "X" button click. Code allows for adding same functionality in other modals.
Related issues
Fixes #2006
Fixes #2011