Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation status fixes #2196

Merged
merged 15 commits into from Mar 19, 2019

Conversation

Projects
None yet
4 participants
@magicznyleszek
Copy link
Member

commented Feb 13, 2019

Description

Fixes two issues, but also this:

  • when editing Validation Status in Submission Modal, it updates in UI after API call finishes
  • when editing Validation Status in Submission Modal, the Table View Validation Status also refreshes

Related issues

Fixes #2188
Fixes #2189

Warning

Do not merge before kobotoolbox/kobocat#525 is reviewed and merged

@magicznyleszek magicznyleszek requested a review from jnm Feb 13, 2019

@Eric-Dilcher Eric-Dilcher self-assigned this Feb 21, 2019

Show resolved Hide resolved jsapp/js/components/table.es6 Outdated
Show resolved Hide resolved jsapp/js/components/table.es6 Outdated

@magicznyleszek magicznyleszek requested a review from Eric-Dilcher Mar 4, 2019

Show resolved Hide resolved jsapp/js/components/table.es6 Outdated
Show resolved Hide resolved kpi/deployment_backends/mixin.py
@jnm

jnm approved these changes Mar 19, 2019

@jnm jnm merged commit d29f374 into master Mar 19, 2019

@jnm jnm deleted the 2188-2189-validation-status-fixes branch Mar 19, 2019

@jnm jnm removed the donotmerge label Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.