Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: disaggregating map results by nested groups questions #2406

Merged
merged 5 commits into from Oct 21, 2019

Conversation

magicznyleszek
Copy link
Member

Description

The problem was because FE code ignored nested groups. I introduced a nice function that generates a list of survey questions with a flat path of each one (could be useful in other places). Added a test for it too.

Related issues

Fixes #1476

@jnm jnm removed the request for review from arsea October 17, 2019 21:56
@jnm jnm force-pushed the 1476-map-nested-groups-bug branch from 49e61dc to 79b732b Compare October 17, 2019 22:18
@jnm jnm changed the base branch from master to two-databases October 17, 2019 22:19
Copy link
Member

@jnm jnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @magicznyleszek, this looks good. One question I have is about QUESTION_TYPES. This is not used by the Coffee code, so I'm guessing it needs to be kept manually in sync with another list. Is this preparation for future work?

@magicznyleszek
Copy link
Member Author

magicznyleszek commented Oct 18, 2019

@jnm in the coffee code unfortunately there is not a single list with configs for question types. If you're referring to jsapp/xlform/src/view.icons.coffee - I can use es6 files there easily (i.e. constants = require '../../js/constants'). I can also build the other config-like places in coffee code using the constant :> Answering your question - I try to not touch the coffee code if I don't need to, as I assume hope it will some day go away 🤞

@magicznyleszek
Copy link
Member Author

@jnm ok I tried it and it was easy and nice - see 8418952 :)

@jnm jnm merged commit 712ed06 into two-databases Oct 21, 2019
@jnm jnm deleted the 1476-map-nested-groups-bug branch October 21, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants