Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ENKETO_SERVER and make it consistent with other app urls #3431

Merged
merged 3 commits into from Sep 22, 2021
Merged

Rename ENKETO_SERVER and make it consistent with other app urls #3431

merged 3 commits into from Sep 22, 2021

Conversation

noliveleger
Copy link
Contributor

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)

Description

To be consistent with KOBOCAT_URL and KOBOFORM_URL:

  • Rename ENKETO_SERVER to ENKETO_URL
  • Remove its trailing slash (and add a leading slash to every concatenation)

Related issues

Fixes #3430

@noliveleger noliveleger added Back end enhancement Ideas, improvements and features labels Aug 23, 2021
@noliveleger noliveleger changed the title Rename ENKETO_SERVER and make it consistent with other apps urls Rename ENKETO_SERVER and make it consistent with other app urls Aug 23, 2021
@noliveleger noliveleger linked an issue Aug 26, 2021 that may be closed by this pull request
Use of trailing slash with ENKETO_SERVER setting is not consistent with other variables #3430
Closed
@joshuaberetta joshuaberetta merged commit 6356f05 into beta Sep 22, 2021
@joshuaberetta joshuaberetta deleted the 3430-enketo-url-without-trailing-slash branch September 22, 2021 21:31
jdugh pushed a commit to geohyd/kpi that referenced this pull request Nov 21, 2022
@joshuaberetta
Merge pull request kobotoolbox#3431 from kobotoolbox/3430-enketo-url-…
9448687 
…without-trailing-slash

Rename `ENKETO_SERVER` and make it consistent with other app urls
jdugh pushed a commit to geohyd/kpi that referenced this pull request Nov 13, 2023
@joshuaberetta
Merge pull request kobotoolbox#3431 from kobotoolbox/3430-enketo-url-…
8dd8ed1 
…without-trailing-slash

Rename `ENKETO_SERVER` and make it consistent with other app urls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaberetta joshuaberetta joshuaberetta approved these changes

Assignees

@joshuaberetta joshuaberetta

Labels
Back end enhancement Ideas, improvements and features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of trailing slash with ENKETO_SERVER setting is not consistent with other variables
2 participants
@noliveleger @joshuaberetta