Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Istio plugin #342

Merged

Conversation

axdotl
Copy link
Contributor

@axdotl axdotl commented Jun 8, 2022

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #342 (911f9cd) into rework-kobs-architecture (8a0abd4) will decrease coverage by 3.34%.
The diff coverage is 7.77%.

@@                     Coverage Diff                      @@
##           rework-kobs-architecture     #342      +/-   ##
============================================================
- Coverage                     46.43%   43.08%   -3.35%     
============================================================
  Files                            98      100       +2     
  Lines                          6803     7485     +682     
============================================================
+ Hits                           3159     3225      +66     
- Misses                         3577     4187     +610     
- Partials                         67       73       +6     
Impacted Files Coverage Δ
plugins/plugin-istio/pkg/instance/instance.go 5.79% <5.79%> (ø)
plugins/plugin-istio/cmd/istio.go 9.79% <9.79%> (ø)
plugins/plugin-prometheus/pkg/instance/instance.go 5.72% <0.00%> (+5.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a0abd4...911f9cd. Read the comment docs.

@ricoberger ricoberger merged commit 563ddd3 into rework-kobs-architecture Jun 9, 2022
@ricoberger ricoberger deleted the rework-kobs-architecture-istio-plugin branch June 9, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants