Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-config-kodefox): Use warn instead of error for import statement order #377

Merged
merged 1 commit into from Mar 9, 2020

Conversation

@sstur
Copy link
Member

sstur commented Mar 9, 2020

The reason for this update is that the red underline on imports usually means there's no module found, so having this use the same level of error is a bit confusing.

Copy link
Member

oshimayoan left a comment

LGTM. 🚢

@oshimayoan oshimayoan added approved and removed ready for review labels Mar 9, 2020
@oshimayoan oshimayoan changed the title ESLint: Use warn instead of error for import statement order fix(eslint-config-kodefox): Use warn instead of error for import statement order Mar 9, 2020
@sstur sstur merged commit adedbfb into master Mar 9, 2020
2 checks passed
2 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: testing Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.