Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-ui: Button #12

Merged
merged 7 commits into from Mar 23, 2020
Merged

core-ui: Button #12

merged 7 commits into from Mar 23, 2020

Conversation

@listiani13
Copy link
Contributor

listiani13 commented Mar 23, 2020

Closes #2
image

@listiani13 listiani13 force-pushed the feat/button branch from 8d7df27 to fa60171 Mar 23, 2020
@sstur sstur changed the title core-ui: button core-ui: Button Mar 23, 2020
@sstur
sstur approved these changes Mar 23, 2020
Copy link
Member

sstur left a comment

Looks good to me!

@@ -3,6 +3,7 @@

export const colors = {
primary: '#0093d5',
white: '#ffffff',

This comment has been minimized.

Copy link
@sstur

sstur Mar 23, 2020

Member

Honestly, I'm fine if you just use colors like white directly in the code without a constant, if that will speed up your development in future.

@@ -27,12 +22,8 @@ export default function GettingStarted() {
'Learn how to protect yourself and your community. Find medical resources to help.',
)}
</Text>
<Button onPress={() => navigate('Home')}>Check Your Health</Button>

This comment has been minimized.

Copy link
@sstur

sstur Mar 23, 2020

Member
Suggested change
<Button onPress={() => navigate('Home')}>Check Your Health</Button>
<Button onPress={() => navigate('Home')}>{t('Check Your Health')}</Button>
@sstur sstur added the approved label Mar 23, 2020
@listiani13 listiani13 force-pushed the feat/button branch from f5c755c to 0d07568 Mar 23, 2020
@listiani13 listiani13 merged commit 94edb7b into master Mar 23, 2020
1 check passed
1 check passed
build
Details
@listiani13 listiani13 deleted the feat/button branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.