Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip getting started for returning user #13

Merged
merged 1 commit into from Mar 23, 2020
Merged

Conversation

@darcien
Copy link
Contributor

darcien commented Mar 23, 2020

Will close #8

src/App.tsx Outdated
{!isReturningUser && (
<Stack.Screen
name="GettingStarted"
component={GettingStartedScreen}
options={{
headerShown: false,
}}
/>
)}
Comment on lines 24 to 32

This comment has been minimized.

Copy link
@sstur

sstur Mar 23, 2020

Member

Might want to consider using initialRoute on the parent component instead of conditionally wrapping the whole thing. But up to you.

This comment has been minimized.

Copy link
@darcien

darcien Mar 23, 2020

Author Contributor

Setting the initial route might need additional works later on when we need to prevent the user from going back to the getting started screen.

Since in react navigation v5 we don't have switch navigator, just stack with logic when rendering.

@darcien darcien force-pushed the feat/started-flow branch from da4e671 to c9766fc Mar 23, 2020
@sstur
sstur approved these changes Mar 23, 2020
Copy link
Member

sstur left a comment

🐑 it!

@sstur sstur added approved and removed ready for review labels Mar 23, 2020
@darcien darcien merged commit 61a006d into master Mar 23, 2020
1 check passed
1 check passed
build
Details
@darcien darcien deleted the feat/started-flow branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.