Isengard: muxer - flush the queued packets with wrong pts on seek #146
Conversation
|
Can you change the PR to point against master directly from Github, or does it not apply cleanly? |
It's really a fatal error. If the predicate is not set to zero, then _PredicateCallbackDefault() function (see platform/mutex.h) gives true return value. It means that Wait() returns ASAP. This also means that m_seekTime must not be set to a zero value in the ParseSubscriptionSkip().
perexg
changed the title
|
The commit 4793806 shows the purpose. Also, Flush() should be called on rewind or FF 4x + . |
…ngeSpeed initialization
|
Why is this only for Isengard? |
|
Sorry, I work only with precompiled binaries (using kodi 15.2 package in Fedora). The packaging is always delayed a bit. But I'll port my changes to master when I finish all tests. |
|
Are all these changes part of #155? |
|
Yes, they're. |
|
Okay. @ksooo do we close this or do you want to make a new release for Isengard with applicable backported patches? I believe OE users would get the update since they use a repository for PVR addons. |
|
What is Isengard? ;-) I do not see a need for an Isengard update- If you ask me, I would close this PR. |
|
That you don't see the need doesn't mean that it's not useful for others. Not everyone is using the latest greatest version number :) |
|
That's why I said "if you ask me". ;-) If others don't share my point of view, I'm fine with this. I will not block an Isengard update. |
|
I've merged in PRs for older releases quite often when people sent updates. Only thing that needs to be taken care of is that you bump the add-on version numbers properly if the APIs or ABIs are incompatible, so you don't get clashes. |
|
@seo will you accept addon bumps for OE 6 even though Isengard development has stoppd? If OE won't use a newer version no one else will since other platforms get the addons shipped with Kodi itself. |
|
There are a lot more distributions out there that we don't control. There's more out there than just Ubuntu, Windows, etc. One of the big advantages of separating core from stuff like this is that add-ons can still be fixed, even though development of core has moved to a new version. That being said, I don't care much if you merge this or not, just commenting on the reasons that you're giving for not merging ;) |
|
@opdenkamp which platforms would that be? As far as I know, OE is the only one with a repository for binary addons. |
|
e.g. any Linux distribution that's not called Ubuntu? |
|
Okay. Let's wait a bit longer before we start backporting stuff in case any fixes show up at the last minute. |
|
@Jalle19 |
|
@Jalle19 |
|
Closing this since master has the fixes applied. I hope to be able to do some backports during the weekend. |
(only for Isengard branch)