Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVR addon API 1.9.6 changes #16

Merged
merged 3 commits into from Mar 17, 2015
Merged

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Mar 17, 2015

#13
#14

Please test and report back.

Note: changelog.txt already contains description for the other PRs I want to include in 2.1.6 (#10, #11, #15)

This was referenced Mar 17, 2015
@@ -66,6 +67,7 @@ struct STag
{
del = false;
id = 0;
index = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably merge #15 first and use the same convention here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the plan.

@Jalle19
Copy link
Contributor

Jalle19 commented Mar 17, 2015

Thanks for the quick fixes! Could you perhaps add a message like (closes #13 etc. to the commits, that way Github will automatically close the issues once merged?

@ksooo
Copy link
Member Author

ksooo commented Mar 17, 2015

Sure. Did not even know about this autoclose-feature.

@Jalle19
Copy link
Contributor

Jalle19 commented Mar 17, 2015

Thanks, merge at will.

ksooo added a commit that referenced this pull request Mar 17, 2015
@ksooo ksooo merged commit cc1b511 into kodi-pvr:master Mar 17, 2015
@ksooo
Copy link
Member Author

ksooo commented Mar 17, 2015

@Jalle19 merged. What needs to be updated in kodi repo to let it pick up the new pvr.hts version?

@xhaggi
Copy link
Contributor

xhaggi commented Mar 17, 2015

@xhaggi
Copy link
Contributor

xhaggi commented Mar 17, 2015

BTW @Jalle19 wow nice thanks a lot ;)

@xhaggi
Copy link
Contributor

xhaggi commented Mar 17, 2015

oops I have to say thank you @ksooo .. thought the PR was from @Jalle19 ;)

@ksooo
Copy link
Member Author

ksooo commented Mar 17, 2015

@xhaggi never mind.

@ksooo ksooo deleted the pvr-api-1-9-6-compat branch March 18, 2015 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants