Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes. #333

Merged
merged 2 commits into from Oct 3, 2017

Conversation

@ksooo
Copy link
Member

commented Oct 2, 2017

Some trivial, but useful/important stuff.

@Jalle19 mind taking a look?

@ksooo ksooo requested a review from Jalle19 Oct 2, 2017
@ksooo ksooo merged commit 619b55e into kodi-pvr:master Oct 3, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ksooo ksooo deleted the ksooo:misc-fixes branch Oct 3, 2017
/**
* Encapsulates an localized string.
*/
class CLocalizedString

This comment has been minimized.

Copy link
@Jalle19

Jalle19 Oct 3, 2017

Contributor

Too late now (didn't see this earlier) but there's no point in prefixes namespaced classes like this. AFAIK the other namespaced classes don't have prefixes either.

This comment has been minimized.

Copy link
@ksooo

ksooo Oct 3, 2017

Author Member

Okay, will change in a follow-up PR. Thanks for spotting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.