Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle time offset in EPG programme start and end times #89

Merged
merged 2 commits into from Oct 8, 2016

Conversation

@ChadiEM
Copy link
Contributor

commented Oct 6, 2016

To solve issue #85 .

@Jalle19

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2016

Can you bump the version to 2.4.4 and update the changelog too? See 6ea17c5 for an example.

@Jalle19

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2016

Thanks!

@Jalle19 Jalle19 merged commit 57b546a into kodi-pvr:master Oct 8, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Jalle19 Jalle19 referenced this pull request Oct 8, 2016
Copy link
Contributor

left a comment

this breaks build addon for windows.

return mktime(&timeinfo);
std::time_t current_time;
std::time(&current_time);
long offset = std::localtime(&current_time)->tm_gmtoff;

This comment has been minimized.

Copy link
@afedchin

afedchin Oct 10, 2016

Contributor

tm_gmtoff is not available on WIN32. please fix this. or I will revert this.

@Jalle19

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2016

Typical, I just trusted Travis.

@ChadiEM

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2016

So did I. Thanks for letting me know @afedchin. Unfortunately, I don't have a Windows machine to develop this change on, so please feel free to amend the change or revert it completely.

@afedchin

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2016

fixed already in #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.