Fixed editing recordings, and recording only new episodes #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please bump the addon version and update the changelog? |
| tag.iTimerType = TIMER_ONCE_EPG_CHILD; | ||
| } | ||
| else | ||
| if (tag.iParentClientIndex != 0) |
There was a problem hiding this comment.
Please use PVR_TIMER_NO_PARENT instead of a 'magic number'.
|
BTW: I reverted the Jarvis commit you did by "accident". Please open a Jarvis PR after(!) we're done with this PR. Please, in case you are uncertain how to do this right, without accidentally pushing stuff directly to the repo, feel free to ask. I suggest reading https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md, which is pretty much identical to how it works for pvr addons. |
…o record only new episodes -Fixed issue where user couldn't select to only record new episodes -Fixed issue with updating one-off recordings -Fixed issue where pre/post padding was not being loaded with recording list
|
I've corrected the items version/changelog, and updated to use PVR_TIMER_NO_PARENT |
|
Cannot say anything about the nextpvr specific code. Otherwise it is looking good. Thanks. |
ksooo
added a commit
that referenced
this pull request
Feb 26, 2016
Fixed editing recordings, and recording only new episodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fixed issue where user couldn't select to only record new episodes
-Fixed issue with updating one-off recordings
-Fixed issue where pre/post padding was not being loaded with recording list