Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuners and signal status #156

Merged
merged 9 commits into from Jan 2, 2019

Conversation

@phunkyfish
Copy link
Member

commented Dec 30, 2018

v3.16.0

  • Added: Tuners and SignalStatus
  • Added: Use Picon Path from OpenWebIf

Introduced the nlohmann/json single header only library to process JSON payloads.

@phunkyfish

This comment has been minimized.

Copy link
Member Author

commented Dec 30, 2018

FYI, the json.hpp included has been patched to get around the windows build issue. Link above is for author to work on resolving.

Copy link
Member

left a comment

I think the strncpy usages should be fixed; the rest is sugar.

src/Enigma2.cpp Outdated Show resolved Hide resolved
src/Enigma2.cpp Outdated Show resolved Hide resolved
src/enigma2/Admin.cpp Outdated Show resolved Hide resolved
src/enigma2/Admin.cpp Show resolved Hide resolved
src/enigma2/Admin.cpp Outdated Show resolved Hide resolved
src/enigma2/Admin.cpp Outdated Show resolved Hide resolved
src/enigma2/Channels.cpp Outdated Show resolved Hide resolved
src/enigma2/Channels.cpp Outdated Show resolved Hide resolved
src/enigma2/Channels.cpp Outdated Show resolved Hide resolved
src/enigma2/Channels.cpp Outdated Show resolved Hide resolved
@phunkyfish

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2019

Happy New Year @ksooo !

@phunkyfish

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2019

It wasn't easy to fixup the changes so used a separate commit. Should be ready to go.

@ksooo
ksooo approved these changes Jan 2, 2019
Copy link
Member

left a comment

Thanks for another contribution. Happy New Year @phunkyfish and keep up the good work. Much appreciated.

@phunkyfish phunkyfish merged commit 0a36332 into kodi-pvr:master Jan 2, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@phunkyfish phunkyfish deleted the phunkyfish:tuners-and-signal-status branch Jan 2, 2019
@phunkyfish

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2019

👍

@Rechi

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

Adding json.hpp from https://github.com/nlohmann/json directly into the git repo is the wrong approach.
It has to be added as dependency.

@phunkyfish

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2019

I’m not entirely sure how to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.