Set SVG property in BaseLayer

koenbok · Jan 15, 2018 · 07ac6677721b879d3185f15ef1ac6eb8faec5d82 · 07ac667
1 parent 3413e12
commit 07ac6677721b879d3185f15ef1ac6eb8faec5d82
Unified Split

Showing with 5 additions and 12 deletions.

+5 −0 framer/SVGBaseLayer.coffee

+0 −7 framer/SVGGroup.coffee

+0 −5 framer/SVGPath.coffee
diff --git a/framer/SVGBaseLayer.coffee b/framer/SVGBaseLayer.coffee
@@ -77,6 +77,11 @@ class exports.SVGBaseLayer extends Layer

 		super(options)

+		for parent in @ancestors()
+			if parent instanceof SVGLayer
+				@_svg = parent.svg
+				break
+
 	@define "gradient",
 		get: ->
 			console.warn "The gradient property is currently not supported on shapes"
diff --git a/framer/SVGGroup.coffee b/framer/SVGGroup.coffee
@@ -9,16 +9,9 @@ class SVGGroup extends SVGBaseLayer
 	constructor: (group, options) ->
 		options.element = group
 		super(options)
-
 		{children, targets} = SVG.constructSVGElements(@, @_element.childNodes, SVGPath, SVGGroup)
 		@_children = children
 		@elements = targets
-
-		for parent in @ancestors()
-			if parent instanceof SVGLayer
-				@_svg = parent.svg
-				break
-
 		SVG.updateGradientSVG(@)

 	@defineGroupProxyProp = (propertyName, validator, transformer) ->
diff --git a/framer/SVGPath.coffee b/framer/SVGPath.coffee
@@ -26,11 +26,6 @@ class exports.SVGPath extends SVGBaseLayer
 		rect = @_element.getBoundingClientRect()
 		@_width = rect.width
 		@_height = rect.height
-		for parent in @ancestors()
-			if parent instanceof SVGLayer
-				@_svg = parent.svg
-				break
-
 		for prop in ["frame", "stroke", "strokeWidth", "strokeLinecap", "strokeLinejoin", "strokeMiterlimit", "strokeDasharray", "strokeDashoffset"]
 			@on "change:#{prop}", @resetViewbox