Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Only update the value when the knob is moved, not when the frame is c…
…hanged in another way.
- Loading branch information
Showing
with
4 additions
and 1 deletion.
@@ -86,7 +86,10 @@ class exports.SliderComponent extends Layer | ||
@on("change:borderRadius", @_setRadius) | ||
@knob.on("change:size", @_updateKnob) | ||
@knob.on("change:frame", @_updateFill) | ||
@knob.on("change:frame", @_updateValue) | ||
|
||
# Only update the value on move events, not on frame change (to prevent events loop) | ||
@knob.on Events.Move, => | ||
This comment has been minimized.
This comment has been minimized.
eelco
Author
Collaborator
|
||
@_updateValue | ||
|
||
@sliderOverlay.on(Events.TapStart, @_touchStart) | ||
@sliderOverlay.on(Events.TapEnd, @_touchEnd) | ||
Hmm you reverted this later, but there is a typo here, you don't call the function.
@_updateValue()