Skip to content
Browse files

Revert "Only update the value when the knob is moved, not when the fr…

…ame is changed in another way."

Reverting because this breaks expected behavior.

This reverts commit 0e4aac0.
  • Loading branch information
eelco committed May 7, 2016
1 parent d80a019 commit 8ce9687ed95cb8364af05712db95894a81277860
Showing with 1 addition and 4 deletions.
  1. +1 −4 framer/Components/
@@ -86,10 +86,7 @@ class exports.SliderComponent extends Layer
@on("change:borderRadius", @_setRadius)
@knob.on("change:size", @_updateKnob)
@knob.on("change:frame", @_updateFill)

# Only update the value on move events, not on frame change (to prevent events loop)
@knob.on Events.Move, =>
@knob.on("change:frame", @_updateValue)

@sliderOverlay.on(Events.TapStart, @_touchStart)
@sliderOverlay.on(Events.TapEnd, @_touchEnd)

0 comments on commit 8ce9687

Please sign in to comment.
You can’t perform that action at this time.