Skip to content
Permalink
Browse files

Revert "Fix issue #86: "Layer registration point vs originX/Y?""

This reverts commit f6400e6.
  • Loading branch information
edwinvanrijkom committed Aug 19, 2015
1 parent c966d49 commit ecf3c54a895267f288d64b8217c60363fe2f24a5
Showing with 1 addition and 0 deletions.
  1. +1 −0 framer/LayerStates.coffee
@@ -138,6 +138,7 @@ class exports.LayerStates extends BaseClass
keys = []

for stateName, state of @_states
continue if stateName is "default"
keys = _.union(keys, _.keys(state))

keys

5 comments on commit ecf3c54

@jchavarri

This comment has been minimized.

Copy link
Contributor

@jchavarri jchavarri replied Aug 19, 2015

@edwinvanrijkom Oops, did that change break something? I'm curious... thanks

@edwinvanrijkom

This comment has been minimized.

Copy link
Contributor Author

@edwinvanrijkom edwinvanrijkom replied Aug 20, 2015

@jchavarri yes, @jornvandijk found that successive calls to State.next() got broken: http://share.framerjs.com/rb75v8suurbm/

@jchavarri

This comment has been minimized.

Copy link
Contributor

@jchavarri jchavarri replied Aug 20, 2015

Thanks @edwinvanrijkom !

I want to help fix this, but I'm not able to replicate the error you show in the example. I have tried with the Framer versions of the last 5 commits in master and all of them work properly.

I also took a look at the framer.js file of the counter example you shared and the animatingKeys function reads as follows:

LayerStates.prototype.animatingKeys=function(){
    var keys,ref,state,stateName;
    keys=[],
    ref=this._states;
    for(stateName in ref)
        state=ref[stateName],"default"!==stateName&&(keys=_.union(keys,_.keys(state)));
    return keys
}

As you can see, it includes the "default"!==stateName exception, so my guess the version of Framer that you used to create this example is not the latest one?

@jchavarri

This comment has been minimized.

Copy link
Contributor

@jchavarri jchavarri replied Aug 20, 2015

What I mean is that maybe the State.next() problem was related to the framer.js version shipped with the latest Framer Studio, and not with commit f6400e6. Does that make any sense?

@koenbok

This comment has been minimized.

Copy link
Owner

@koenbok koenbok replied Sep 7, 2015

Thanks for the fix, and sorry for the delay. This seem to be working fine now!

Please sign in to comment.